Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm create next-app for latest pnpm 6 and 7 #37254

Merged
merged 2 commits into from
May 27, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented May 27, 2022

This command changed in pnpm 6.32.13 and 7.1.1 so lets update it since its been a few weeks and we can expect pnpm users to update more regularly than npm users.

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. area: documentation examples Issue/PR related to examples created-by: Next.js team PRs by the Next.js team. labels May 27, 2022
@styfle styfle changed the title Update pnpm create next-app for pnpm 7.1.1 Update pnpm create next-app for latest pnpm 6 and 7 May 27, 2022
@ijjk
Copy link
Member

ijjk commented May 27, 2022

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
buildDuration 16.5s 16.5s ⚠️ +1ms
buildDurationCached 6.6s 6.7s ⚠️ +66ms
nodeModulesSize 626 MB 626 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
/ failed reqs 0 0
/ total time (seconds) 3.934 3.946 ⚠️ +0.01
/ avg req/sec 635.5 633.56 ⚠️ -1.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.44 1.437 0
/error-in-render avg req/sec 1736.06 1740 +3.94
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
buildDuration 18.9s 19s ⚠️ +108ms
buildDurationCached 6.6s 6.6s -5ms
nodeModulesSize 626 MB 626 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
/ failed reqs 0 0
/ total time (seconds) 3.952 3.966 ⚠️ +0.01
/ avg req/sec 632.62 630.32 ⚠️ -2.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.391 1.408 ⚠️ +0.02
/error-in-render avg req/sec 1797.55 1776.16 ⚠️ -21.39
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.9 kB 2.9 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update-pnpm-create-next-app-v7 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 95bad59

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 57dcc9d into canary May 27, 2022
@kodiakhq kodiakhq bot deleted the update-pnpm-create-next-app-v7 branch May 27, 2022 21:21
@balazsorban44 balazsorban44 mentioned this pull request Jun 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants